Big, Ugly Patch #350
Big, Ugly Patch #350
Conversation
* Performs YAML resolution in Python, using lib/yaml_resolver.py * Adds many missing extensions * Changes Profile schema to match other objects * Implements versioning via lib/version.rb instead of Gem::Version/Requirement * Refactors ArchDef into Specification/Config * Simplifies ArchDef/Specification by exploiting common format for object schemas * New, simplified schema for configs * Adds schemas for profile (some are still placeholders) * Parallelizes GitHub regression test fixes #336 fixes #320 fixes #319 fixes #317 fixes #299
james-ball-qualcomm
assigned james-ball-qualcomm and dhower-qc and unassigned james-ball-qualcomm and dhower-qc
|
Don't see how to add additional comments to my review so I'll just add them here. Why did the Profiles get put into their own files instead of inside a ProfileRelease? |
|
Recommend removing any knowledge of Specification and/or ArchDef classes from Config. Derek proposed removing the Config methods that use ArchDef. |
|
What happened to the initializers for Certificate classes? Are those now auto-created by some Ruby magic? If so, can you add comments to the classes that use this since readability is impacted. |
|
Can you please update arch/README.adoc since it is stale? |
done |
|
@AFOliveira, @BrianAnakPintar do you have patches ready? If so, let's merge yours first and I'll handle any conflicts with this patch. |
|
only #340 but you fix that in this PR, right? |
Yes, I do. |
|
Nothing on my end for now. @AFOliveira, I might need some help regarding the extensions. |
A Big, Ugly Patch
fixes #336
fixes #320
fixes #319
fixes #317
fixes #299