Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

local/global clarification #436

Merged
merged 6 commits into from
Oct 29, 2024
Merged

local/global clarification #436

merged 6 commits into from
Oct 29, 2024

Conversation

tariqkurd-repo
Copy link
Collaborator

Fix #432

arichardson
arichardson reviewed Oct 29, 2024
View reviewed changes
src/level-ext.adoc Outdated Show resolved Hide resolved
arichardson
arichardson reviewed Oct 29, 2024
View reviewed changes
Copy link
Collaborator

@arichardson arichardson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the added condition on the load is not correct, but otherwise the changes look good.

@tariqkurd-repo @arichardson
Update src/level-ext.adoc
4739fa1 
Co-authored-by: Alexander Richardson <[email protected]>
Signed-off-by: Tariq Kurd <[email protected]>
@tariqkurd-repo
Copy link
Collaborator Author

I think the added condition on the load is not correct, but otherwise the changes look good.

which condition?

@davidchisnall
Copy link

@nwf

LawrenceEsswood
LawrenceEsswood reviewed Oct 29, 2024
View reviewed changes
src/level-ext.adoc Outdated Show resolved Hide resolved
@arichardson
Copy link
Collaborator

I think the added condition on the load is not correct, but otherwise the changes look good.

which condition?

The one you just removed (the authorizing <<section_cap_level>> is _local_). Looks good now.

@tariqkurd-repo tariqkurd-repo merged commit f509f2b into riscv:main Oct 29, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LawrenceEsswood LawrenceEsswood LawrenceEsswood approved these changes

@arichardson arichardson arichardson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

EL permission rules clarification
4 participants
@tariqkurd-repo @davidchisnall @arichardson @LawrenceEsswood