fix(meta): fix time travel GC bug #20108
Merged
+57
−28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
type/fix
8 tasks
zwang28
force-pushed
the
wangzheng/fix_gc
branch
from
eb82d16 to
5aec856
Compare
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 11, 2025
Co-authored-by: zwang28 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
This PR fixes the time travel GC bug that may incorrectly delete objects still being used.
The bug is more likely to arise in situations of very high I/O latency.
The bug was introduced in version 2.1.0, so version 2.0 or earlier are not affected.
Checklist
Documentation
Release note