Disable rollForward for SDK in global.json #170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Code Climate has analyzed commit 48f1955 and detected 0 issues on this pull request. View more on Code Climate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update .NET SDK to the latest released version and disable
rollForward.Updates to the .NET SDK feature band can introduce new / updated analyzers (for instance, 8.0.400 adds IDE0320). As a result, updating the feature band isn't "safe" to do from a build reproducibility perspective. It will also conflict with #166.
That means the roll forward options available to us are:
patchlatestPatchdisableHowever, GitHub Actions don't support these options (tracked by actions/setup-dotnet#448). Thus, the only
rollForwardstrategy that currently does the same thing locally and in CI isdisabled.Once 448 is fixed, we can / should probably switch to
latestPatch(tracked by #171).This 'gotcha' is also added to the SquiggleCop documentation here.