Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ems v3.87, mc4plus v3.90, mc2plus 3.69, amc 2.2 and bat v1.3.4 #146

Merged
merged 1 commit into from
Mar 26, 2024

Conversation

MSECode
Copy link
Contributor

@MSECode MSECode commented Mar 21, 2024

Changes in this PR:

  • Update status bat to uint16_t for struct eOas_battery_timedvalue_t valid for both BAT and BMS devices
  • Add total absorbed current to BAT yarp port
  • Set BAT port voltage as the INPUT voltage
  • Move the calculation of the BAT Battery_Charge from the methods related to the display only to a proper place with an ad-hoc function
  • Add to diagnostic parser overheating error
  • Re-elaborate status bat-bms using uint16_t as datatype and using string_view instead of string for status messages
    Update bat reading values adding total absorbed current in BAT and adjusting limits for BAT SoC calculation
  • Fix datatype in diagnostic to be aligned by raw value datatype Set value of battery charge to NaN if equal to zero
  • Update MINIMUM_REQUIRED_icub_firmware_shared_VERSION to 1.38.2
  • Update bat v1.3.4, ems v3.87, mc4plus v3.90, mc2plus 3.69, amc 2.2

Related to:

Copy link
Member

@valegagge valegagge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@marcoaccame marcoaccame left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @MSECode, the following PR needs some changes that require recompilation of the binaries:

@MSECode MSECode force-pushed the feature/batUpdate branch from 2268451 to 9585b2b Compare March 25, 2024 10:42
@MSECode MSECode requested a review from marcoaccame March 25, 2024 10:43
@MSECode MSECode force-pushed the feature/batUpdate branch from 9585b2b to 26606b8 Compare March 26, 2024 14:52
@MSECode
Copy link
Contributor Author

MSECode commented Mar 26, 2024

Hi @MSECode, the following PR needs some changes that require recompilation of the binaries:

Hi @marcoaccame,
Updated protocol version to 1.11 in eth/embobj/plus/comm-v2/protocol/api/EoProtocolAS.h and pushed udpated binaries

Copy link
Contributor

@marcoaccame marcoaccame left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, thanks

@marcoaccame marcoaccame merged commit 8922829 into robotology:devel Mar 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants