Fix RgbdSensor_nws_ros2 camera data and distortion type handling #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
kaidegast
commented
Nov 29, 2024
kaidegast
commented
- Optimized camera data handling: Data is now retrieved only during the first iteration and stored in a class variable, avoiding repeated requests in every cycle.
- Distortion management: Support for the none distortion type has been added, eliminating errors and reducing the number of log messages generated by yarprobotinterface.
Optimized camera data handling: Data is now retrieved only during the first iteration and stored in a class variable, avoiding repeated requests in every cycle. Distortion management: Support for the none distortion type has been added, eliminating errors and reducing the number of log messages generated by yarprobotinterface.
|
|
Thanks a lot @kaidegast ! This may be quite useful also for other robots using |
|
Great! Then i can say all the necessary changes have been applied. I have marked the PR as ready for review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.