Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: address C4's issue#32 #34

Merged
merged 2 commits into from
Nov 18, 2024
Merged

Conversation

thaixuandang
Copy link
Collaborator

Description

Based on the recommendation from @khangvv and the security team, I added a check in verifyCallback to ensure that msg.sender is a pool, not an exploit address. I also retained the logic to verify using computePoolAddress, as suggested.

Notice that this modification, besides impacting NonfungiblePositionManager, will also affect the QuoterV2 and MixedRouteQuoterV1 contracts.

Checklist

  • I have clearly commented on all the main functions following the NatSpec Format
  • The box that allows repo maintainers to update this PR is checked
  • I tested locally to make sure this feature/fix works

@thaixuandang thaixuandang merged commit e59ece0 into release/v1.0.0 Nov 18, 2024
1 check passed
@thaixuandang thaixuandang deleted the feature/c4-issue-32 branch November 21, 2024 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants