Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add windows build #158

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add windows build #158

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 29 additions & 0 deletions .github/workflows/jazzy-build-win.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,29 @@
name: Windows Binary Build
# author: Christoph Fröhlich <[email protected]>
# description: 'Build & test all dependencies from released (binary) windows packages.'

on:
workflow_dispatch:
pull_request:
branches:
- master
# types:
# - labeled
push:
branches:
- master
# issue_comment:
# types:
# - created

jobs:
binary-windows:
# if: |
# (github.event_name == 'issue_comment' && contains(github.event.comment.body, '/check-windows')) ||
# (github.event_name == 'pull_request' && contains(github.event.label.name, 'check-windows')) ||
# (github.event_name == 'workflow_dispatch')
Comment on lines +21 to +24
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Am I correct in assuming the comments are relate to the next increment of rolling out this CI? I'm not sure I understand the future use of the issue_comment and pull_requests types.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah sorry, I haven't added the reference to ros-controls/realtime_tools#204
I was just adding these comments to get reminded of this possibility in case the windows build do not work well, or take way more time then all the other jobs.

uses: ros-controls/ros2_control_ci/.github/workflows/reusable-ros-tooling-win-build.yml@master
with:
ros_distro: jazzy
ref_for_scheduled_build: master
os_name: windows-2019