-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added IO Gripper Control and Configuration Messages, Services, and Actions #164
Open
sachinkum0009
wants to merge
16
commits into
ros-controls:master
Choose a base branch
from
StoglRobotics-forks:gripper-io-msg
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
65b2736
Added IOGripperController msgs.
destogl aece6f9
Update actions, add action for Gripper (open/close) and setting a
mamueluth 5ea829d
Merge branch 'ros-controls:master' into gripper-io-msg
sachinkum0009 4b40c30
fix: standardize end-of-file formatting in control_msgs
sachinkum0009 ebcff47
Update CMakeLists.txt
destogl 90a82bf
Rename IoGripperSensor.msg to IOGripperSensor.msg
destogl af79a5c
renamed interface names and added doc
sachinkum0009 e823a9e
removed whitespace line
sachinkum0009 db1f368
Merge branch 'master' into gripper-io-msg
destogl d1d054a
Update code for states
sachinkum0009 c02e54b
configuration names modified
sachinkum0009 5aeb6d2
configuration names modified
sachinkum0009 d460ba8
pre-commit fix
sachinkum0009 017ed60
doc updated for states
sachinkum0009 49f4a85
Update messges to have better status from the gripper.
destogl 4427a63
pre-commit fix
sachinkum0009 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,11 @@ | ||
# This action interface is defined for controlling the io gripper controller to open or close the gripper | ||
|
||
# The grippers are going through the different states during opening and closing process. | ||
# Those are returned as feedback. | ||
|
||
bool open # boolean value to indicate if the gripper should be opened or closed (e.g. true for open, false for close) | ||
--- | ||
bool success # true for performing the gripper command successfully and vice versa | ||
string message # informational, e.g. for success or error messages | ||
--- | ||
IOGripperState transition # state of the gripper during transition as defined above |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,13 @@ | ||
# This action interface is defined for setting the configuration of the io gripper controller | ||
# In yaml file of the io_gripper_controller, the configuration is defined as a list of strings | ||
# e.g. configurations: ["narrow_objects", "wide_objects"] | ||
# The action request is called with the name of the configuration to be set | ||
|
||
# The io_gripper_controller follows a set of states to reconfigure the gripper | ||
|
||
string config_name # information about which configuration is being set for the gripper controller | ||
--- | ||
bool result # indicate success for setting the configuration of the gripper controller and vice versa | ||
string status # informational, e.g. for success or error messages | ||
--- | ||
IOGripperState transition # state of the gripper during transition as defined above |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
# Name of the gripper open close state. Note that it can have multiple "closed" states. If empty, then transition is happening and check the state of the transition. | ||
string open_close | ||
IOGripperState open_close_transition | ||
|
||
# Name of the gripper's current configuration. If empty, then transition is happening and check the state of the transition. | ||
string configuration | ||
IOGripperState configuration_transition |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,21 @@ | ||
# The grippers are going through the different states during opening, closing, and configuration changes process. | ||
|
||
# The gripper is in an idle state, not performing any action. | ||
uint8 IDLE=0 | ||
# The gripper is setting command interfaces to be able to perform open or close action, e.g., disabling breaks. | ||
uint8 SET_BEFORE_COMMAND=1 | ||
# (optional) Check if before command is set correctly and confirmed by the sensors. | ||
uint8 CHECK_BEFORE_COMMAND=2 | ||
# Set command to gripper's command interfaces. | ||
uint8 SET_COMMAND=11 | ||
# The controller is checking its current gripper's state on state interfaces. | ||
uint8 CHECK_COMMAND=12 | ||
# The gripper is setting "after" commands when open or close process if finished, e.g., engaging breaks. | ||
uint8 SET_AFTER_COMMAND=21 | ||
# (optional) Check if after command is set correctly and confirmed by the sensors. | ||
uint8 CHECK_AFTER_COMMAND=22 | ||
# The gripper has halted due to an error or stop command. | ||
uint8 HALTED=100 | ||
|
||
# state of the gripper during transitions as defined above | ||
uint8 state |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,9 @@ | ||
# This service interface is defined for setting the configuration of the io gripper controller | ||
# In yaml file of the io_gripper_controller, the configuration is defined as a list of strings | ||
# e.g. configurations: ["narrow_objects", "wide_objects"] | ||
# The service request is called with the name of the configuration to be set | ||
|
||
string config_name # information about which configuration is being set for the gripper controller | ||
--- | ||
bool result # indicate success for setting the configuration of the gripper controller and vice versa | ||
string status # informational, e.g. for success or error messages |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can this be clarified. Looking at this message I expect the contents of this string to be
open
orclose
. If it's that, it could be number of some kind. But I think I'm misinterpreting it. Maybeopen_close_configuration
and naming the other string in the messagecurrent_configuration