Apply suggestions from code review

Co-authored-by: Sai Kishor Kothakota <[email protected]>
ros-controls · Dec 18, 2024 · 44a8734 · 44a8734
1 parent fc06593
commit 44a8734
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/include/control_toolbox/pid_ros.hpp b/include/control_toolbox/pid_ros.hpp
@@ -368,7 +368,7 @@ class CONTROL_TOOLBOX_PUBLIC PidROS
    *               If not stated explicitly using "/" or "~", prefix is interpreted as global, i.e.,
    *               "/" will be added in front of topic prefix
    */
-  void set_prefixes(std::string topic_prefix);
+  void set_prefixes(const std::string &topic_prefix);
 
   rclcpp::node_interfaces::OnSetParametersCallbackHandle::SharedPtr parameter_callback_;
 

diff --git a/src/pid_ros.cpp b/src/pid_ros.cpp
@@ -92,7 +92,7 @@ PidROS::PidROS(
     new realtime_tools::RealtimePublisher<control_msgs::msg::PidState>(state_pub_));
 }
 
-void PidROS::set_prefixes(std::string topic_prefix)
+void PidROS::set_prefixes(const std::string &topic_prefix)
 {
   param_prefix_ = topic_prefix;
   // If it starts with a "~", remove it