Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Eigen CMake target #190

Merged
merged 3 commits into from
Mar 4, 2024

Conversation

christophfroehlich
Copy link
Contributor

I changed the CMake file to use Eigen's CMake target as described here https://eigen.tuxfamily.org/dox/TopicCMakeGuide.html

This fixes #178 for RHEL 8

@codecov-commenter
Copy link

codecov-commenter commented Feb 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 50.10%. Comparing base (759d954) to head (f01404c).

Additional details and impacted files
@@             Coverage Diff              @@
##           ros2-master     #190   +/-   ##
============================================
  Coverage        50.10%   50.10%           
============================================
  Files               10       10           
  Lines              497      497           
  Branches           166      166           
============================================
  Hits               249      249           
  Misses             217      217           
  Partials            31       31           
Flag Coverage Δ
unittests 50.10% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@saikishor
Copy link
Member

@christophfroehlich is this missing a test_msgs dependency?

@christophfroehlich
Copy link
Contributor Author

No, rosdep fails for realtime_tools (see also ros-controls/realtime_tools#154)
[MIRROR] ros-humble-test-msgs-1.2.1-1.el8.20231117.182020.x86_64.rpm: Status code: 404 for http://packages.ros.org/ros2/rhel/8/x86_64/Packages/r/ros-humble-test-msgs-1.2.1-1.el8.20231117.182020.x86_64.rpm (IP: 140.211.166.134)
I'm already debugging why, when I run it locally it installs ros-humble-test-msgs-1.2.1-1.el8.20240217.042201.x86_64 which is fine, maybe it's because metadata were updated

Last metadata expiration check: 22:01:48 ago on Fri Feb 23 00:55:05 2024.

I'm already building new docker containers, if this fixes it I'll add the missing apt update-equivalent to the rhel build.

@saikishor
Copy link
Member

Awesome!

@christophfroehlich
Copy link
Contributor Author

The RHEL job still needs an update ros-controls/ros2_control_ci#19

@bmagyar bmagyar merged commit 02a9e3a into ros-controls:ros2-master Mar 4, 2024
19 checks passed
@christophfroehlich christophfroehlich deleted the fix_eigen branch April 4, 2024 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RHEL 8 build with eigen
4 participants