Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump version of pre-commit hooks and run only once per month #198

Merged
merged 2 commits into from
Apr 15, 2024

Conversation

github-actions[bot]
Copy link
Contributor

This pull request contains auto-updated files of the pre-commit config. @ros-controls/ros2-maintainers please run the pre-commit workflow manually on the branch auto-update- before merging.

@christophfroehlich christophfroehlich changed the title Bump version of pre-commit hooks Bump version of pre-commit hooks and run only once per month Apr 14, 2024
@christophfroehlich christophfroehlich marked this pull request as ready for review April 14, 2024 13:45
Copy link
Member

@saikishor saikishor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. @christophfroehlich The commits from GitHub actions bot should avoid the reviewer lottery right? Or am I wrong?

@christophfroehlich christophfroehlich merged commit b2ae538 into ros2-master Apr 15, 2024
17 of 18 checks passed
@christophfroehlich christophfroehlich deleted the auto-update- branch April 15, 2024 15:19
@christophfroehlich
Copy link
Contributor

LGTM. @christophfroehlich The commits from GitHub actions bot should avoid the reviewer lottery right? Or am I wrong?

Yes, and it should be excluded here. But maybe the github.actor is Bence in this case (see the first commit), because he was the last one doing something in this repo (can't remember now, but that's the downside of adding PRs with the github-actions bot user).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants