Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename save_iterm to save_i_term #285

Merged
merged 1 commit into from
Feb 13, 2025
Merged

Conversation

christophfroehlich
Copy link
Contributor

Copy link
Member

@saikishor saikishor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 53.84615% with 6 lines in your changes missing coverage. Please review.

Project coverage is 72.47%. Comparing base (5cbdeae) to head (aba8292).

Files with missing lines Patch % Lines
src/pid_ros.cpp 25.00% 6 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##           ros2-master     #285   +/-   ##
============================================
  Coverage        72.47%   72.47%           
============================================
  Files               24       24           
  Lines             1239     1239           
  Branches            89       87    -2     
============================================
  Hits               898      898           
  Misses             294      294           
  Partials            47       47           
Flag Coverage Δ
unittests 72.47% <53.84%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
include/control_toolbox/pid.hpp 77.77% <ø> (ø)
include/control_toolbox/pid_ros.hpp 100.00% <ø> (ø)
src/pid.cpp 78.18% <100.00%> (ø)
test/pid_ros_parameters_tests.cpp 100.00% <100.00%> (ø)
test/pid_tests.cpp 100.00% <ø> (ø)
src/pid_ros.cpp 58.55% <25.00%> (ø)

@christophfroehlich christophfroehlich merged commit 155613f into ros2-master Feb 13, 2025
20 checks passed
@christophfroehlich christophfroehlich deleted the rename_param branch February 13, 2025 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants