Fix crashing due to an invalid parameter in the initial value. #271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmagyar
reviewed
Jan 24, 2024
|
@bmagyar As pipeline is fixed I assume that failed action cloud be trigger again. |
ahcorde
approved these changes
Feb 12, 2024
|
https://github.com/Mergifyio backport humble iron |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Feb 12, 2024
Co-authored-by: Alejandro Hernández Cordero <[email protected]> (cherry picked from commit cdae6b8) # Conflicts: # gazebo_ros2_control/src/gazebo_system.cpp
mergify bot
pushed a commit
that referenced
this pull request
Feb 12, 2024
Co-authored-by: Alejandro Hernández Cordero <[email protected]> (cherry picked from commit cdae6b8) # Conflicts: # gazebo_ros2_control/src/gazebo_system.cpp
This was referenced Feb 12, 2024
ahcorde
added a commit
that referenced
this pull request
Feb 13, 2024
…ort #271) (#283) * Fix crashing due to an invalid parameter in the initial value. (#271) Co-authored-by: Alejandro Hernández Cordero <[email protected]> (cherry picked from commit cdae6b8) # Conflicts: # gazebo_ros2_control/src/gazebo_system.cpp * Fixed crash Signed-off-by: Alejandro Hernandez Cordero <[email protected]> --------- Signed-off-by: Alejandro Hernandez Cordero <[email protected]> Co-authored-by: Wiktor Bajor <[email protected]> Co-authored-by: Alejandro Hernandez Cordero <[email protected]>
ahcorde
added a commit
that referenced
this pull request
Feb 13, 2024
…ort #271) (#282) * Fix crashing due to an invalid parameter in the initial value. (#271) Co-authored-by: Alejandro Hernández Cordero <[email protected]> (cherry picked from commit cdae6b8) # Conflicts: # gazebo_ros2_control/src/gazebo_system.cpp * Fixed merge Signed-off-by: Alejandro Hernandez Cordero <[email protected]> --------- Signed-off-by: Alejandro Hernandez Cordero <[email protected]> Co-authored-by: Wiktor Bajor <[email protected]> Co-authored-by: Alejandro Hernandez Cordero <[email protected]>
k-takeshita
pushed a commit
to hsr-project/gazebo_ros2_control
that referenced
this pull request
Oct 21, 2024
…ort ros-controls#271) (ros-controls#282) * Fix crashing due to an invalid parameter in the initial value. (ros-controls#271) Co-authored-by: Alejandro Hernández Cordero <[email protected]> (cherry picked from commit cdae6b8) # Conflicts: # gazebo_ros2_control/src/gazebo_system.cpp * Fixed merge Signed-off-by: Alejandro Hernandez Cordero <[email protected]> --------- Signed-off-by: Alejandro Hernandez Cordero <[email protected]> Co-authored-by: Wiktor Bajor <[email protected]> Co-authored-by: Alejandro Hernandez Cordero <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix crashes caused by the wrong initial value in the state interfaces. This could be particularly problematic if someone passes 'pi' in xacro instead of '${pi}'. Xacro will evaluate '${pi}' to '3.14', while 'pi' will be evaluated as is ('pi' -> 'pi'), leading to chrash.