-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rewrite mimic joints #297
Rewrite mimic joints #297
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR overall looks good to me. Thanks for the changes. I left few comments for clarification
Co-authored-by: Sai Kishor Kothakota <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thank you for the changes :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested locally, LGTM, just two minor comments
gazebo_ros2_control_demos/launch/gripper_mimic_joint_example_position.launch.py
Outdated
Show resolved
Hide resolved
Co-authored-by: Alejandro Hernández Cordero <[email protected]>
The component_parser of the resource_manager now already parses the mimic joint information from the URDF. The old way for defining it in the
ros2_control
tag is deprecated, see ros-controls/ros2_control#1256.If this one is approved, I'll make the same changes for gz_ros2_control as well.
hardware_info
structure instead of parsing it again._mimic
):$ ros2 control list_hardware_interfaces command interfaces right_finger_joint/position [available] [claimed] state interfaces left_finger_joint/effort left_finger_joint/position left_finger_joint/velocity right_finger_joint/effort right_finger_joint/position right_finger_joint/velocity