Harden behavior if a joint is not found in the model #325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Mergifyio backport iron |
✅ Backports have been created
|
ahcorde
pushed a commit
that referenced
this pull request
Jun 10, 2024
|
https://github.com/Mergifyio backport jazzy |
ahcorde
approved these changes
Jun 10, 2024
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Jun 10, 2024
* Don't crash if a joint does not exist (cherry picked from commit 5d2d5eb)
mergify bot
pushed a commit
that referenced
this pull request
Jun 10, 2024
* Don't crash if a joint does not exist (cherry picked from commit 5d2d5eb)
This was referenced Jun 10, 2024
ahcorde
added a commit
that referenced
this pull request
Jun 10, 2024
* Don't crash if a joint does not exist (cherry picked from commit 5d2d5eb) Co-authored-by: Christoph Fröhlich <[email protected]> Co-authored-by: Alejandro Hernández Cordero <[email protected]>
ahcorde
pushed a commit
that referenced
this pull request
Jun 10, 2024
* Don't crash if a joint does not exist (cherry picked from commit 5d2d5eb) Co-authored-by: Christoph Fröhlich <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As reported with #323, the plugin crashes if there is a wrong config.
I suggest skipping if it the joint is not in the
enableJointsmap.