Refactor yet another method and fix include

ros-controls · May 10, 2023 · ae12b90 · ae12b90
1 parent e0a439a
commit ae12b90
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/hardware_interface/src/component_parser.cpp b/hardware_interface/src/component_parser.cpp
@@ -224,7 +224,7 @@ std::string parse_data_type_attribute(const tinyxml2::XMLElement * elem)
 bool parse_is_async_attribute(const tinyxml2::XMLElement * elem)
 {
   const tinyxml2::XMLAttribute * attr = elem->FindAttribute(kIsAsyncAttribute);
-  return attr ? strcasecmp(attr->Value(), "true") == 0 : false;
+  return parse_bool(attr->Value());
 }
 
 /// Search XML snippet from URDF for parameters.

diff --git a/hardware_interface/src/mock_components/generic_system.cpp b/hardware_interface/src/mock_components/generic_system.cpp
@@ -25,7 +25,7 @@
 #include <string>
 #include <vector>
 
-#include "hardware_interface/component_parser.h"
+#include "hardware_interface/component_parser.hpp"
 #include "hardware_interface/types/hardware_interface_type_values.hpp"
 #include "rcutils/logging_macros.h"
 
@@ -99,7 +99,7 @@ CallbackReturn GenericSystem::on_init(const hardware_interface::HardwareInfo & i
   it = info_.hardware_parameters.find("fake_gpio_commands");
   if (it != info_.hardware_parameters.end())
   {
-    use_fake_gpio_command_interfaces = hardware_interface::parse_bool(it->second);
+    use_fake_gpio_command_interfaces_ = hardware_interface::parse_bool(it->second);
   }
   else
   {