Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CM] Remove deprecation warning #1101

Merged

Conversation

christophfroehlich
Copy link
Contributor

This got deprecated in December, I think it's time to remove the noisy deprecation warning.

@bmagyar
Copy link
Member

bmagyar commented Aug 17, 2023

Could remove it from the msg too but for that I think we need to branch for iron...

We are beginnign to have a pile of stuff now that'd justify branching

@codecov-commenter
Copy link

Codecov Report

Merging #1101 (3a9eb52) into master (925f5f3) will decrease coverage by 2.78%.
Report is 510 commits behind head on master.
The diff coverage is 31.53%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##           master    #1101      +/-   ##
==========================================
- Coverage   34.61%   31.84%   -2.78%     
==========================================
  Files          52       94      +42     
  Lines        2981    10473    +7492     
  Branches     1855     7128    +5273     
==========================================
+ Hits         1032     3335    +2303     
- Misses        310      801     +491     
- Partials     1639     6337    +4698     
Flag Coverage Δ
unittests 31.84% <31.53%> (-2.78%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
controller_manager/src/controller_manager.cpp 38.62% <ø> (-1.09%) ⬇️
controller_manager/src/ros2_control_node.cpp 0.00% <0.00%> (ø)
..._interface/include/hardware_interface/actuator.hpp 100.00% <ø> (ø)
...ce/include/hardware_interface/async_components.hpp 0.00% <0.00%> (ø)
...re_interface/include/hardware_interface/sensor.hpp 100.00% <ø> (ø)
...re_interface/include/hardware_interface/system.hpp 100.00% <ø> (ø)
...erface/src/mock_components/fake_generic_system.cpp 100.00% <ø> (ø)
...e_interface/src/mock_components/generic_system.cpp 52.29% <ø> (ø)
hardware_interface/src/resource_manager.cpp 46.76% <ø> (-6.87%) ⬇️
hardware_interface/src/sensor.cpp 50.52% <ø> (ø)
... and 69 more

... and 21 files with indirect coverage changes

@bmagyar bmagyar merged commit 132dd28 into ros-controls:master Nov 6, 2023
1 check passed
@christophfroehlich christophfroehlich deleted the rm_classtype_warning branch November 6, 2023 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants