[ControllerManager] Fix all warnings from the latets features.

[destogl]

I have fixed following warnings:

src/ros2_control/controller_manager/src/controller_manager.cpp:2509:35: warning: conversion from ‘std::__iterator_traits<__gnu_cxx::__normal_iterator<const controller_manager::ControllerSpec*, std::vector<controller_manager::ControllerSpec> >, void>::difference_type’ {aka ‘long int’} to ‘int’ may change value [-Wconversion]
2509 |           int dist = std::distance(controllers.begin(), it);

src/ros2_control/controller_manager/test/test_controller_failed_init/test_controller_failed_init.cpp:36:16: warning: unused parameter ‘cm_update_rate’ [-Wunused-parameter]
36 |   unsigned int cm_update_rate, const std::string & /*namespace_*/,

src/ros2_control/controller_manager/test/test_controller_manager.cpp:486:33: warning: conversion from ‘long unsigned int’ to ‘double’ may change value [-Wconversion]
486 |         (controller_update_rate * no_of_secs_passed), 1);

src/ros2_control/controller_manager/test/test_controller_manager_srvs.cpp:816:25: warning: conversion from ‘std::__iterator_traits<__gnu_cxx::__normal_iterator<controller_manager_msgs::msg::ControllerState_<std::allocator<void> >*, std::vector<controller_manager_msgs::msg::ControllerState_<std::allocator<void> >, std::allocator<controller_manager_msgs::msg::ControllerState_<std::allocator<void> > > > >, void>::difference_type’ {aka ‘long int’} to ‘int’ may change value [-Wconversion]
816 |     return std::distance(result->controller.begin(), it);

src/ros2_control/controller_manager/test/test_controller_manager_srvs.cpp:1025:25: warning: conversion from ‘std::__iterator_traits<__gnu_cxx::__normal_iterator<controller_manager_msgs::msg::ControllerState_<std::allocator<void> >*, std::vector<controller_manager_msgs::msg::ControllerState_<std::allocator<void> >, std::allocator<controller_manager_msgs::msg::ControllerState_<std::allocator<void> > > > >, void>::difference_type’ {aka ‘long int’} to ‘int’ may change value [-Wconversion]
1025 |     return std::distance(result->controller.begin(), it);

src/ros2_control/controller_manager/src/controller_manager.cpp:2513:67: warning: conversion from ‘long int’ to ‘int’ may change value [-Wconversion]
2513 |       const int ctrl_a_chain_first_controller = find_first_element(following_ctrls);

src/ros2_control/controller_manager/src/controller_manager.cpp:2514:67: warning: conversion from ‘long int’ to ‘int’ may change value [-Wconversion]
2514 |       const int ctrl_b_chain_first_controller = find_first_element(following_ctrls_b);

src/ros2_control/controller_manager/src/controller_manager.cpp:2512:7: warning: control reaches end of non-void function [-Wreturn-type]

src/ros2_control/controller_manager/test/test_controller_manager.cpp:486:56: warning: conversion from ‘long unsigned int’ to ‘double’ may change value [-Wconversion]
486 |         (static_cast<double>(controller_update_rate) * no_of_secs_passed), 1.0);

@saikishor please check the changes one more time! I ahve added some default values to return lambda. The tests are passing, but maybe this cases are not covered.

[codecov]

Codecov Report

Merging #1174 (1e65f73) into master (99d2f61) will increase coverage by 0.01%.
The diff coverage is 42.85%.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #1174      +/-   ##
==========================================
+ Coverage   47.61%   47.63%   +0.01%     
==========================================
  Files          40       40              
  Lines        3444     3445       +1     
  Branches     1866     1866              
==========================================
+ Hits         1640     1641       +1     
  Misses        480      480              
  Partials     1324     1324              

Flag	Coverage Δ
unittests	47.63% <42.85%> (+0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files	Coverage Δ
controller_manager/src/controller_manager.cpp	38.70% <42.85%> (+0.05%)	⬆️

[saikishor]

Apart from that, the changes look minimal and good to me.
Thank you @destogl for the great work

[saikishor]

@destogl We can merge it as it is, it shouldn't make a big difference in the tests point of view. SO, in my opinion we can go ahead

[destogl]

@Mergifyio backport iron humble

[mergify]

backport iron humble

✅ Backports have been created

• #1308 [ControllerManager] Fix all warnings from the latets features. (backport #1174) has been created for branch iron but encountered conflicts
• #1309 [ControllerManager] Fix all warnings from the latets features. (backport #1174) has been created for branch humble but encountered conflicts