Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ControllerManager] Fix all warnings from the latets features. (backport #1174) #1309

Merged
merged 3 commits into from
Jan 17, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Jan 17, 2024

This is an automatic backport of pull request #1174 done by Mergify.
Cherry-pick of 7d79464 has failed:

On branch mergify/bp/humble/pr-1174
Your branch is up to date with 'origin/humble'.

You are currently cherry-picking commit 7d79464.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   controller_manager/src/controller_manager.cpp
	modified:   controller_manager/test/test_controller_manager_srvs.cpp

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   controller_manager/test/test_controller_failed_init/test_controller_failed_init.cpp
	both modified:   controller_manager/test/test_controller_manager.cpp

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/github/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally


Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

(cherry picked from commit 7d79464)

# Conflicts:
#	controller_manager/test/test_controller_failed_init/test_controller_failed_init.cpp
#	controller_manager/test/test_controller_manager.cpp
Copy link
Contributor Author

mergify bot commented Jan 17, 2024

This pull request is in conflict. Could you fix it @bmagyar @destogl @christophfroehlich?

@destogl destogl merged commit 7a3a4a1 into humble Jan 17, 2024
12 checks passed
@destogl destogl deleted the mergify/bp/humble/pr-1174 branch January 17, 2024 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant