Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initialize the controller manager services after initializing resource manager #1271

Merged
merged 3 commits into from
Jan 8, 2024
Merged

Initialize the controller manager services after initializing resource manager #1271

merged 3 commits into from
Jan 8, 2024

Conversation

saikishor
Copy link
Member

@saikishor saikishor commented Jan 5, 2024 •
edited
Loading

Exposing CM services before initializing the resource manager might be a bad idea as the spawners might trigger the controller activation even before the actual system is ready. Exposing it later, might avoid such issues

Fixes #1262

@saikishor saikishor mentioned this pull request Jan 5, 2024
Closed
@saikishor saikishor marked this pull request as draft January 5, 2024 13:00
@codecov Codecov
Copy link

codecov bot commented Jan 5, 2024 •
edited
Loading

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (64c9e2a) 47.89% compared to head (7ae58d8) 47.87%.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #1271      +/-   ##
==========================================
- Coverage   47.89%   47.87%   -0.03%     
==========================================
  Files          41       41              
  Lines        3451     3453       +2     
  Branches     1876     1878       +2     
==========================================
  Hits         1653     1653              
  Misses        444      444              
- Partials     1354     1356       +2
Flag Coverage Δ
unittests 47.87% <0.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
controller_manager/src/controller_manager.cpp 39.15% <0.00%> (-0.07%) ⬇️

@saikishor saikishor marked this pull request as ready for review January 5, 2024 15:04
olivier-stasse
olivier-stasse approved these changes Jan 5, 2024
View reviewed changes
Copy link
Contributor

@olivier-stasse olivier-stasse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@dyackzan dyackzan mentioned this pull request Jan 5, 2024
Merged
dyackzan
dyackzan approved these changes Jan 5, 2024
View reviewed changes
Copy link

@dyackzan dyackzan left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pulled and tested these changes into my humble setup and saw my issues resolved as discussed in: #1262

@saikishor saikishor mentioned this pull request Jan 6, 2024
Closed
@bmagyar bmagyar merged commit bdad009 into ros-controls:master Jan 8, 2024
14 checks passed
mergify bot pushed a commit that referenced this pull request Jan 8, 2024
@saikishor @mergify
Initialize the controller manager services after initializing resourc…
1e923b9 
…e manager (#1271)

(cherry picked from commit bdad009)

# Conflicts:
#	controller_manager/src/controller_manager.cpp
@mergify mergify bot mentioned this pull request Jan 8, 2024
Merged
bmagyar pushed a commit that referenced this pull request Jan 8, 2024
@mergify
Initialize the controller manager services after initializing resourc…
9387936 
…e manager (backport #1271) (#1278)
This was referenced Jan 16, 2024
Merged
Merged
HovorunB added a commit to pixel-robotics/ros2_control that referenced this pull request Jan 17, 2024
@HovorunB
Revert "Initialize the controller manager services after initializing…
8d42dd4 
… resource manager (backport ros-controls#1271) (ros-controls#1278)"

This reverts commit 9387936.
@HovorunB HovorunB mentioned this pull request Jan 17, 2024
Merged
@saikishor saikishor deleted the init_srvs_after_resource_manager_init branch August 17, 2024 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dyackzan dyackzan dyackzan approved these changes

@bmagyar bmagyar bmagyar approved these changes

@olivier-stasse olivier-stasse olivier-stasse approved these changes

@aprotyas aprotyas Awaiting requested review from aprotyas

@arne48 arne48 Awaiting requested review from arne48

@bijoua29 bijoua29 Awaiting requested review from bijoua29

@DasRoteSkelett DasRoteSkelett Awaiting requested review from DasRoteSkelett

@destogl destogl Awaiting requested review from destogl

@VanshGehlot VanshGehlot Awaiting requested review from VanshGehlot

@livanov93 livanov93 Awaiting requested review from livanov93

@VX792 VX792 Awaiting requested review from VX792

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Loading robot_description from topic does not work as expected
4 participants
@saikishor @olivier-stasse @bmagyar @dyackzan