Add service call timeout argument in spawner #1808
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 22, 2024 12:02
Signed-off-by: Angsa Deployment Team <[email protected]>
Signed-off-by: Angsa Deployment Team <[email protected]>
github-actions
bot
requested review from
bijoua29,
bmagyar,
christophfroehlich,
destogl,
erickisos,
livanov93 and
olivier-stasse
Merged
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1808 +/- ##
==========================================
+ Coverage 87.97% 88.01% +0.03%
==========================================
Files 121 121
Lines 12403 12404 +1
Branches 1105 1105
==========================================
+ Hits 10912 10917 +5
+ Misses 1085 1083 -2
+ Partials 406 404 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
|
christophfroehlich
requested changes
Oct 25, 2024
There was a problem hiding this comment.
LGTM, but please rebase/merge on master and update the release_notes and docs as I've done in this PR.
Signed-off-by: Tony Najjar <[email protected]>
Done. I believe CI is failing not because of this PR |
Co-authored-by: Christoph Fröhlich <[email protected]>
christophfroehlich
previously approved these changes
Nov 6, 2024
Signed-off-by: Tony Najjar <[email protected]>
Signed-off-by: Tony Najjar <[email protected]>
|
I rebased to master and resolved conflicts caused by https://github.com/ros-controls/ros2_control/pull/1790/files. Could you please review @christophfroehlich @saikishor |
christophfroehlich
previously approved these changes
Nov 22, 2024
saikishor
reviewed
Nov 25, 2024
| @@ -124,6 +128,13 @@ def main(args=None): | |||
| default=5.0, | |||
| type=float, | |||
| ) | |||
| parser.add_argument( | |||
| "--controller-manager-call-timeout", | |||
There was a problem hiding this comment.
can we change this to --service-call--timeout? just to have a shorter naming? I'm saying as in future if we add more services, then it would be more generic.
@christophfroehlich what's your opinion on this one?
There was a problem hiding this comment.
I changed it already. It's an easy revert if @christophfroehlich disagrees. I don't have any strong opinion
Signed-off-by: Tony Najjar <[email protected]>
Co-authored-by: Sai Kishor Kothakota <[email protected]>
saikishor
approved these changes
Nov 25, 2024
christophfroehlich
added
the
backport-humble
christophfroehlich
merged commit 41d7393
into
ros-controls:master
19 of 20 checks passed
mergify bot
pushed a commit
that referenced
this pull request
Nov 25, 2024
--------- Signed-off-by: Angsa Deployment Team <[email protected]> Signed-off-by: Tony Najjar <[email protected]> Co-authored-by: Angsa Deployment Team <[email protected]> Co-authored-by: Christoph Fröhlich <[email protected]> Co-authored-by: Sai Kishor Kothakota <[email protected]> (cherry picked from commit 41d7393) # Conflicts: # controller_manager/controller_manager/controller_manager_services.py # controller_manager/doc/userdoc.rst # doc/release_notes.rst
christophfroehlich
added a commit
that referenced
this pull request
Nov 25, 2024
--------- Signed-off-by: Angsa Deployment Team <[email protected]> Signed-off-by: Tony Najjar <[email protected]> Co-authored-by: Angsa Deployment Team <[email protected]> Co-authored-by: Christoph Fröhlich <[email protected]> Co-authored-by: Sai Kishor Kothakota <[email protected]>
christophfroehlich
pushed a commit
that referenced
this pull request
Dec 16, 2024
--------- Signed-off-by: Angsa Deployment Team <[email protected]> Signed-off-by: Tony Najjar <[email protected]> Co-authored-by: Tony Najjar <[email protected]> Co-authored-by: Angsa Deployment Team <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR exposes the call_timeout of the spawner to be optionally set by the user