fake_sensor_commands renamed #782
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
a10263790,
bmagyar,
destogl,
harderthan,
homalozoa,
kellyprankin and
mcbed
Codecov Report
@@ Coverage Diff @@
## master #782 +/- ##
==========================================
- Coverage 34.61% 32.62% -2.00%
==========================================
Files 52 91 +39
Lines 2981 9268 +6287
Branches 1855 6229 +4374
==========================================
+ Hits 1032 3024 +1992
- Misses 310 720 +410
- Partials 1639 5524 +3885
Flags with carried forward coverage won't be shown. Click here to find out more.
|
kvkpraneeth
force-pushed
the
mock_sensor_commands
branch
from
8aaffb3 to
455b464
Compare
|
@bmagyar if deprecation is in place we should merge this. |
|
This pull request is in conflict. Could you fix it @kvkpraneeth? |
bmagyar
reviewed
Sep 28, 2022
hardware_interface/test/mock_components/test_generic_system.cpp
Outdated
Show resolved
Hide resolved
bmagyar
previously approved these changes
Sep 28, 2022
hardware_interface/test/mock_components/test_generic_system.cpp
Outdated
Show resolved
Hide resolved
destogl
previously approved these changes
Oct 11, 2022
destogl
approved these changes
Oct 11, 2022
|
@Mergifyio backport humble |
mergify bot
pushed a commit
that referenced
this pull request
Oct 11, 2022
…ds' (#782) Co-authored-by: Bence Magyar <[email protected]> Co-authored-by: Denis Štogl <[email protected]> (cherry picked from commit 1cf9bf2) # Conflicts: # hardware_interface/test/mock_components/test_generic_system.cpp
✅ Backports have been created
|
|
@Mergifyio backport humble |
✅ Backports have been created
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves #774 issue to refactor all of
fake_sensor_commandstomock_sensor_commands, Also adds a small deprecation warning iffake_sensor_commandsis used.