Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[doc] Remove a duplicate hint #507

Merged

Conversation

VladimirFokow
Copy link
Contributor

@VladimirFokow VladimirFokow commented May 1, 2024

General

That hint repeats 2 times.
I've removed one of them:

  • Joint names in <ros2_control> tags in the URDF must be compatible with the controller's configuration.

here

(It can be backported to humble as well)

Copy link
Member

@saikishor saikishor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the changes!

Copy link
Contributor

@christophfroehlich christophfroehlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@christophfroehlich christophfroehlich merged commit a4cccb1 into ros-controls:master May 3, 2024
4 of 9 checks passed
mergify bot pushed a commit that referenced this pull request May 3, 2024
(cherry picked from commit a4cccb1)
mergify bot pushed a commit that referenced this pull request May 3, 2024
(cherry picked from commit a4cccb1)
christophfroehlich pushed a commit that referenced this pull request May 3, 2024
(cherry picked from commit a4cccb1)

Co-authored-by: Vladimir Fokow <[email protected]>
christophfroehlich pushed a commit that referenced this pull request May 3, 2024
(cherry picked from commit a4cccb1)

Co-authored-by: Vladimir Fokow <[email protected]>
@VladimirFokow VladimirFokow deleted the remove-duplicate-hint branch May 3, 2024 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants