Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

About min_acceleration when reversing #1317

Closed
otamachan opened this issue Oct 22, 2024 · 4 comments · Fixed by #1315
Closed

About min_acceleration when reversing #1317

otamachan opened this issue Oct 22, 2024 · 4 comments · Fixed by #1315

Comments

@otamachan
Copy link

Is your feature request related to a problem? Please describe.
I am using the diff_drive_controller, and I want the robot to accelerate slowly when speeding up and decelerate quickly to come to a stop. To achieve this, I have set min_acceleration and max_acceleration, and the robot behaves as expected when moving forward. However, when reversing, the acceleration is fast, and the deceleration is slow, so it does not work as expected.

Describe the solution you'd like
Would it be better to reverse the handling of min_acceleration and max_acceleration when reversing?

Describe alternatives you've considered

Additional context
I found the similar issue in ros_controllers(ros-controls/ros_controllers#290)

@otamachan
Copy link
Author

might be related to ros-controls/control_toolbox#212

@christophfroehlich
Copy link
Contributor

Thanks for reporting this, I'll have a look and fix that maybe with (or after) the PR in control_toolbox. We have a newer implementation of the speed limiter in the tricycle_controller package, where there is also a min_deceleration and max_deceleration parameter. Maybe we should consider using that one for all controllers, but it has different parameters and I'm not sure if we should change the well-established ones from diff_drive_controller.

@christophfroehlich
Copy link
Contributor

@otamachan could you have a look at #1315 please and see if it solves your problem?

@otamachan
Copy link
Author

Great!! I'll try. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants