Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

effort_controllers/joint_position_controller from ROS1 #373

Open
tonylitianyu opened this issue Jun 29, 2022 · 11 comments
Open

effort_controllers/joint_position_controller from ROS1 #373

tonylitianyu opened this issue Jun 29, 2022 · 11 comments

Comments

@tonylitianyu
Copy link

ros1_controllers has effort_controllers/joint_position_controller that accepts position commands and targets an effort-controlled joint. But in this repo, the effort_controllers only accept group effort commands. Is it moved somewhere else or the feature is still missing?

@tonylitianyu
Copy link
Author

To be more specific, I am trying to control an arm to a set joint position, but with limited torque, so that when an external force (larger than the torque limit) is present, the arm will deviate from the position (with some kind of compliant behavior). Once the external force is gone or become smaller, the arm will tend to move back to the set joint position. Basically some kind of passive motion. Back in ROS1, I can achieve such behavior with effort_controllers/joint_position_controller. I am wondering if ros2_controller has something similar to this.

@bmagyar
Copy link
Member

bmagyar commented Jul 5, 2022 via email

@tonylitianyu
Copy link
Author

@bmagyar Just realize #198 has the group version for this a year ago, is there a reason why it has not merged yet? Would be happy to contribute to this.

@bmagyar
Copy link
Member

bmagyar commented Jul 6, 2022

It needs revival :)

@destogl
Copy link
Member

destogl commented Sep 26, 2022

@tonylitianyu you wanted to contribute to this. Is this still the case?

@tonylitianyu
Copy link
Author

@destogl Given my recent schedule, it would be difficult. Sorry about that.

@Aadiv1999
Copy link

@bmagyar i am trying to build the effort_controller: joint_position_controller from here, but I keep getting build errors for Humble, is there any new branch with a fix for this?

@bmagyar
Copy link
Member

bmagyar commented Nov 8, 2022

There was a sync a few days ago. If you rosdep update && rosdep install --from-path src --ignore-src, it should build fine again.

@Aadiv1999
Copy link

@bmagyar I tried that, but i still seem to be getting errors while building. To give you an idea of my setup:

  • Ubuntu 22.04
  • ROS2 Humble
  • In my home directory, ros2 workspace (ros2_ws)
  • I have the binary install of ros2_controls and ros2_controllers (ros-humble-ros2-control and ros-humble-ros2-controllers)
  • In ~/ros2_ws/src i have cloned the effort_controllers package from here

here is the error message I get while building.

@bmagyar
Copy link
Member

bmagyar commented Nov 9, 2022 via email

@Aadiv1999
Copy link

Aadiv1999 commented Nov 9, 2022

@bmagyar yes I did try, it is still giving me build issues/issues in the code itself as shown in the attached file. Besides, I removed the binary install for the “effort_controllers” package, and I was getting the same errors

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants