[CI] Update list of reviewers #884
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
aprotyas,
duringhof,
LukasMacha97 and
VX792
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #884 +/- ##
==========================================
+ Coverage 46.78% 47.17% +0.38%
==========================================
Files 41 41
Lines 3862 3862
Branches 1816 1816
==========================================
+ Hits 1807 1822 +15
+ Misses 801 786 -15
Partials 1254 1254
Flags with carried forward coverage won't be shown. Click here to find out more. |
aprotyas
reviewed
Dec 6, 2023
😀 it would have worsen your stats not commenting on it |
destogl
force-pushed
the
ci/reviewer_lottery
branch
from
6d4cd1e to
231f715
Compare
destogl
approved these changes
Dec 11, 2023
christophfroehlich
added
backport-humble
mergify bot
pushed a commit
that referenced
this pull request
Dec 12, 2023
(cherry picked from commit 0a96cbb) # Conflicts: # .github/reviewer-lottery.yml
mergify bot
pushed a commit
that referenced
this pull request
Dec 12, 2023
(cherry picked from commit 0a96cbb)
This was referenced Dec 12, 2023
christophfroehlich
added a commit
that referenced
this pull request
Dec 12, 2023
* Update list of reviewers (#884) (cherry picked from commit 0a96cbb) # Conflicts: # .github/reviewer-lottery.yml * Update reviewer-lottery.yml --------- Co-authored-by: Christoph Fröhlich <[email protected]>
bmagyar
pushed a commit
that referenced
this pull request
Dec 12, 2023
henrygerardmoore
pushed a commit
to henrygerardmoore/ros2_controllers
that referenced
this pull request
Jul 19, 2024
…os-controls#884) * Deactivate hardware from read/write return value * Added tests to DEACTIVATE return value * Use constants for defining of special test-values for different HW behaviors --------- Co-authored-by: Dr. Denis <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I created a python script parsing closed reviews of a repository and making some statistics: reviewers_ros-controls_ros2_controllers_2023-12-04.csv
Thanks for the work of lots of active reviewers!
But to make that process more efficient, I removed all reviewers from the list which
a) never finished any review
b) haven't reviewed anything in 2023
Additionally, I promote the following reviewers having already more than approx. 10 reviews and being still active :)
@fmauch
@moriarty
@olivier-stasse
@saikishor
(I think they have to be added to the organisation as well)
What do you think? I'd update that for all other repositories of ros-controls.