Fix for issues 10 & 22: remove wrong and unneeded 'requires' entry from setup args #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ros-industrial-attic#10 and fix ros-industrial-attic#22. The 'python-' prefix of the 'pymodbus' entry was not correct: only the debian package has that prefix. It caused the setup phase to fail, which made the robotiq docjob error out. It was also the reason for 'catkin_make install' not completing. instead of correcting the entry, the entire 'requires' key was removed from the setup args. Catkin packages should not be installed using the 'setup.py' file, and the dependency on 'python-modbus' is already expressed in the pkg manifest.
|
Btw: the manifests and build scripts of all pkgs could use some work. See also #26. |
|
Ping? The Hydro buildfarm is nearing EOL, would be nice if the docs could be generated at least once? |
nicolaslauzier
added a commit
that referenced
this pull request
May 19, 2015
Fix for issues 10 & 22: remove wrong and unneeded 'requires' entry from setup args
|
I'd recommend this be cherry picked into the Or would you prefer I open PRs against those branches? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should make the docjob(s) run to completion again and make
catkin_make installwork again.I opted to remove the entire
requiresentry as it is unneeded:setup.pyUpon acceptance this should probably be cherry-picked into
groovy-develandhydro-devel.Perhaps a quick re-release of
hydro-develis then in order, as the buildfarm will be disabled soon.