Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace xacro.py to xacro --inorder #241

Merged
merged 2 commits into from
Nov 1, 2018
Merged

Replace xacro.py to xacro --inorder #241

merged 2 commits into from
Nov 1, 2018

Conversation

youtalk
Copy link
Contributor

@youtalk youtalk commented Aug 30, 2018

This PR fixes ros-industrial/industrial_training#220 issue.

Environment:

  • OS: Ubuntu 16.04
  • ROS: Kinetic

gavanderhoorn
gavanderhoorn approved these changes Nov 1, 2018
View reviewed changes
Copy link
Member

@gavanderhoorn gavanderhoorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR.

For Kinetic this is still needed.

@gavanderhoorn gavanderhoorn merged commit 6ee9b60 into ros-industrial:kinetic-devel Nov 1, 2018
@youtalk youtalk deleted the xacro-inorder branch November 1, 2018 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gavanderhoorn gavanderhoorn gavanderhoorn approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Replace xacro.py to xacro --inorder
2 participants
@youtalk @gavanderhoorn