-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Backport/wait for server timeout #4261
Backport/wait for server timeout #4261
Conversation
@bektaskemal, all pull requests must be targeted towards the |
* Make BT nodes have configurable wait times. Previous solution provided hardcoded 1s value. Right now the value can be configured for BT Action, Cancel and Service nodes. [ros-navigation#3920] Signed-off-by: Adam Galecki <[email protected]> * Make BT nodes have configurable wait times. Previous solution provided hardcoded 1s value. Right now the value can be configured for BT Action, Cancel and Service nodes. [ros-navigation#3920] Signed-off-by: Adam Galecki <[email protected]> * Fix typos, linting errors and value type from float to int * Fix extra underscores * Fix extra underscore * Update unit tests with blackboard parameter Signed-off-by: Adam Galecki <[email protected]> * Fix formatting errors Signed-off-by: Adam Galecki <[email protected]> * Update system tests to match new parameter Signed-off-by: Adam Galecki <[email protected]> --------- Signed-off-by: Adam Galecki <[email protected]> Signed-off-by: Kemal Bektas <[email protected]>
…os-navigation#4178) Signed-off-by: Felix <[email protected]> Co-authored-by: Felix <[email protected]> Signed-off-by: Kemal Bektas <[email protected]>
335534e
to
c0d2787
Compare
This seems fine to me. Please run the full |
I tested locally and two test failed for me but they seems irrelevant:
This one might be related to behaviortree_cpp_v3 version but I'm not sure.
Here is the issue that error codes are in Goal and not Result, but this is wrong in iron branch: https://github.com/ros-planning/navigation2/blob/iron/nav2_system_tests/src/gps_navigation/tester.py#L187 |
Backports #3960 and #4178 to iron.
We would like to have this on iron if possible.