-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix rviz crash if launch later #4882
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: mini-1235 <[email protected]>
Signed-off-by: mini-1235 <[email protected]>
Signed-off-by: mini-1235 <[email protected]>
Signed-off-by: mini-1235 <[email protected]>
I now add the |
Codecov ReportAll modified and coverable lines are covered by tests ✅ |
SteveMacenski
requested changes
Jan 29, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Otherwise, small thing to update and should be good to go!
Signed-off-by: mini-1235 <[email protected]>
SteveMacenski
approved these changes
Jan 29, 2025
mergify bot
pushed a commit
that referenced
this pull request
Jan 29, 2025
* Fix rviz crash if start later Signed-off-by: mini-1235 <[email protected]> * Bring back default rviz launch file Signed-off-by: mini-1235 <[email protected]> * New line Signed-off-by: mini-1235 <[email protected]> * Whitespace Signed-off-by: mini-1235 <[email protected]> * Add log when failed Signed-off-by: mini-1235 <[email protected]> --------- Signed-off-by: mini-1235 <[email protected]> (cherry picked from commit 4192372)
7 tasks
SteveMacenski
pushed a commit
that referenced
this pull request
Jan 29, 2025
* Fix rviz crash if start later Signed-off-by: mini-1235 <[email protected]> * Bring back default rviz launch file Signed-off-by: mini-1235 <[email protected]> * New line Signed-off-by: mini-1235 <[email protected]> * Whitespace Signed-off-by: mini-1235 <[email protected]> * Add log when failed Signed-off-by: mini-1235 <[email protected]> --------- Signed-off-by: mini-1235 <[email protected]> (cherry picked from commit 4192372) Co-authored-by: mini-1235 <[email protected]>
masf7g
pushed a commit
to quasi-robotics/navigation2
that referenced
this pull request
Jan 30, 2025
* Fix rviz crash if start later Signed-off-by: mini-1235 <[email protected]> * Bring back default rviz launch file Signed-off-by: mini-1235 <[email protected]> * New line Signed-off-by: mini-1235 <[email protected]> * Whitespace Signed-off-by: mini-1235 <[email protected]> * Add log when failed Signed-off-by: mini-1235 <[email protected]> --------- Signed-off-by: mini-1235 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basic Info
Description of contribution in a few bullet points
Revival of #4871 targeting the main branch with improved code
get_parameter()
would not block the main thread. The combo box will now have value if it successfully gets the parameter, otherwise emptyDescription of documentation updates required from your changes
None
Description of how this change was tested
Extensively tested on tb3 simulation and all tests passed
Future work that may be required in bullet points
For Maintainers: