Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rviz crash if launch later #4882

Merged
merged 5 commits into from
Jan 29, 2025

Conversation

mini-1235
Copy link
Contributor


Basic Info

Info Please fill out this column
Ticket(s) this addresses #4754
Primary OS tested on Ubuntu 24.04
Robotic platform tested on turtlebot 3 simulation
Does this PR contain AI generated software? No

Description of contribution in a few bullet points

Revival of #4871 targeting the main branch with improved code

  • Open a new thread to load plugins, to ensure that get_parameter() would not block the main thread. The combo box will now have value if it successfully gets the parameter, otherwise empty

Description of documentation updates required from your changes

None

Description of how this change was tested

Extensively tested on tb3 simulation and all tests passed


Future work that may be required in bullet points

For Maintainers:

  • Check that any new parameters added are updated in docs.nav2.org
  • Check that any significant change is added to the migration guide
  • Check that any new features OR changes to existing behaviors are reflected in the tuning guide
  • Check that any new functions have Doxygen added
  • Check that any new features have test coverage
  • Check that any new plugins is added to the plugins page
  • If BT Node, Additionally: add to BT's XML index of nodes for groot, BT package's readme table, and BT library lists

@mini-1235 mini-1235 changed the title Dev rviz crash Fix rviz crash if launch later Jan 29, 2025
Signed-off-by: mini-1235 <[email protected]>
Signed-off-by: mini-1235 <[email protected]>
@mini-1235
Copy link
Contributor Author

I now add the combo_box->addItem("Default"); after we have loaded the parameter successfully, but I can move it before loading the plugin if you think it is better

Copy link

codecov bot commented Jan 29, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

see 6 files with indirect coverage changes

Copy link
Member

@SteveMacenski SteveMacenski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise, small thing to update and should be good to go!

nav2_rviz_plugins/src/selector.cpp Show resolved Hide resolved
Signed-off-by: mini-1235 <[email protected]>
@SteveMacenski SteveMacenski merged commit 4192372 into ros-navigation:main Jan 29, 2025
11 checks passed
mergify bot pushed a commit that referenced this pull request Jan 29, 2025
* Fix rviz crash if start later

Signed-off-by: mini-1235 <[email protected]>

* Bring back default rviz launch file

Signed-off-by: mini-1235 <[email protected]>

* New line

Signed-off-by: mini-1235 <[email protected]>

* Whitespace

Signed-off-by: mini-1235 <[email protected]>

* Add log when failed

Signed-off-by: mini-1235 <[email protected]>

---------

Signed-off-by: mini-1235 <[email protected]>
(cherry picked from commit 4192372)
SteveMacenski pushed a commit that referenced this pull request Jan 29, 2025
* Fix rviz crash if start later

Signed-off-by: mini-1235 <[email protected]>

* Bring back default rviz launch file

Signed-off-by: mini-1235 <[email protected]>

* New line

Signed-off-by: mini-1235 <[email protected]>

* Whitespace

Signed-off-by: mini-1235 <[email protected]>

* Add log when failed

Signed-off-by: mini-1235 <[email protected]>

---------

Signed-off-by: mini-1235 <[email protected]>
(cherry picked from commit 4192372)

Co-authored-by: mini-1235 <[email protected]>
masf7g pushed a commit to quasi-robotics/navigation2 that referenced this pull request Jan 30, 2025
* Fix rviz crash if start later

Signed-off-by: mini-1235 <[email protected]>

* Bring back default rviz launch file

Signed-off-by: mini-1235 <[email protected]>

* New line

Signed-off-by: mini-1235 <[email protected]>

* Whitespace

Signed-off-by: mini-1235 <[email protected]>

* Add log when failed

Signed-off-by: mini-1235 <[email protected]>

---------

Signed-off-by: mini-1235 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[nav2_rviz_plugins/Selector] Unable to set goal pose if we run rviz2 later
2 participants