Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

switch non testing build to devel #1020

Merged
merged 3 commits into from
Aug 23, 2024

Conversation

mikeferguson
Copy link
Member

No description provided.

@mikeferguson
Copy link
Member Author

mikeferguson commented Aug 6, 2024

@ahcorde this is now failing for the right reasons (hpp file not present) - but I know it's not the cleanest approach - is there a better docker container we should be using? Or maybe we just manually define the ROS_DISTRO variable here in the config.yaml? (I've not really worked with GitHub CI recently...)

EDIT: in theory, we can also remove a bunch of the apt configuration stuff in the build-rolling-testing job, since the docker is already using the ros2-testing debian repository

@mikeferguson mikeferguson requested a review from ahcorde August 6, 2024 02:17
@mikeferguson
Copy link
Member Author

Re-running CI now that rolling sync is out - I expect all tests to pass (and then I'll merge this)

@mikeferguson mikeferguson merged commit dbf697d into ros-perception:rolling Aug 23, 2024
5 of 6 checks passed
@mikeferguson mikeferguson deleted the test_released branch August 23, 2024 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants