ros2 fixed async request #838
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Assigning myself to test this out - going to do a pass through the calibration tickets in the next two weeks |
mikeferguson
added
the
needs testing
|
It looks like #792 actually fixed this in a different way (by switching away from async entirely). I think we should instead port that back to humble (it's already in rolling and iron) |
mikeferguson
pushed a commit
that referenced
this pull request
Aug 19, 2024
Backport from #792 to fix #838 Co-authored-by: Christian Rauch <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the Humble version, there is a bug: when you click 'commit' after calibration, an error appears:
Upon inspecting the code, the issue seems to be related to asynchronous requests:
The request is sent, but the second function checks the response before it has actually arrived. I believe the solution is to send both asynchronous requests and then wait for the responses.