image_rotate: clean up #862
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikeferguson
commented
Jan 19, 2024
| "Topic 'image' has not been remapped! Typical command-line usage:\n" | ||
| "\t$ ros2 run image_rotate image_rotate image:=<image topic>"); | ||
| return 1; | ||
| } |
There was a problem hiding this comment.
This debug message didn't work at all - made a more robust version by checking the overlap of our topic name with the actual topics that exist (as many of our depth_image_proc stuff does)
mikeferguson
commented
Jan 19, 2024
| if (subscriber_count_) { // @todo: Could do this without an interruption at some point. | ||
| unsubscribe(); | ||
| subscribe(); | ||
| } |
There was a problem hiding this comment.
this is unneeded - none of the parameters that are able to be updated would impact how the subscribers would actually be setup
25 tasks
ahcorde
approved these changes
Jan 19, 2024
Kotochleb
pushed a commit
to Kotochleb/image_pipeline
that referenced
this pull request
May 27, 2024
This is the first component/node with a cleanup pass to be fully implemented: * Fix ros-perception#740 by initializing vectors. Do this by declaring parameters AFTER we define the callback * Implement lazy subscribers (I missed this in the earlier PRs) * Add image_transport parameter so we can specify that desired transport of our subscriptions * Update how we test for connectivity (and update the debug message - has nothing to do with whether we are remapped, it's really about whether we are connected)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first component/node with a cleanup pass to be fully implemented: