Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for floating point fps #866

Merged
merged 2 commits into from
Jan 19, 2024
Merged

Add support for floating point fps #866

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9eabf63
Add support for floating point fps
ahcorde Jan 19, 2024
487105a
Fixed warning
ahcorde Jan 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion image_view/include/image_view/video_recorder_node.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ class VideoRecorderNode
rclcpp::Time g_last_wrote_time;
std::string encoding;
std::string codec;
int fps;
double fps;
double min_depth_range;
double max_depth_range;
bool use_dynamic_range;
Expand Down
4 changes: 2 additions & 2 deletions image_view/src/video_recorder_node.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ VideoRecorderNode::VideoRecorderNode(const rclcpp::NodeOptions & options)

filename = this->declare_parameter("filename", std::string("output.avi"));
stamped_filename = this->declare_parameter("stamped_filename", false);
fps = this->declare_parameter("fps", 15);
fps = this->declare_parameter("fps", 15.0);
codec = this->declare_parameter("codec", std::string("MJPG"));
encoding = this->declare_parameter("encoding", std::string("bgr8"));
// cv_bridge::CvtColorForDisplayOptions
Expand Down Expand Up @@ -111,7 +111,7 @@ void VideoRecorderNode::callback(const sensor_msgs::msg::Image::ConstSharedPtr &

RCLCPP_INFO(
this->get_logger(),
"Starting to record %s video at %ix%i@%i fps. Press Ctrl+C to stop recording.",
"Starting to record %s video at %ix%i@%.2f fps. Press Ctrl+C to stop recording.",
codec.c_str(), size.height, size.width, fps);
}

Expand Down
Loading