image_proc: consistent image_transport #884
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
25 tasks
ahcorde
requested changes
Jan 19, 2024
| @@ -52,14 +52,34 @@ namespace image_proc | |||
| CropNonZeroNode::CropNonZeroNode(const rclcpp::NodeOptions & options) | |||
| : Node("CropNonZeroNode", options) | |||
| { | |||
| // TransportHints does not actually declare the parameter | |||
| this->declare_parameter<std::string>("image_transport", "raw"); | |||
There was a problem hiding this comment.
string is already in the header file for this class - hence why the linter is asking for it to be added in this file
| @@ -52,7 +52,14 @@ namespace image_proc | |||
| DebayerNode::DebayerNode(const rclcpp::NodeOptions & options) | |||
| : Node("DebayerNode", options) | |||
| { | |||
| auto qos_profile = getTopicQosProfile(this, "image_raw"); | |||
| // TransportHints does not actually declare the parameter | |||
| this->declare_parameter<std::string>("image_transport", "raw"); | |||
ahcorde
approved these changes
Jan 19, 2024
Kotochleb
pushed a commit
to Kotochleb/image_pipeline
that referenced
this pull request
May 27, 2024
* consistent image_transport parameter for crop_decimate, crop_non_zero and debayer nodes * consistent remapping support for compressed/etc topics in all three nodes * add lazy subscription support to crop_non_zero Additional minor fixes: * put the getTopicQosProfile() for publisher right in front of publisher declaration for clarity
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional minor fixes: