default to encoding in the image message #921
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahcorde
approved these changes
Jan 31, 2024
Kotochleb
pushed a commit
to Kotochleb/image_pipeline
that referenced
this pull request
May 27, 2024
My camera is publishing rgb8 encoding - the existing code throws an error that 8UC3 is not a valid encoding, but if we pass rgb8 from the message then things work fine. The encoding in the image should always be more descriptive than just the bit and channel size. If encoding is not filled in, the existing behavior is used as a fallback
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My camera is publishing rgb8 encoding - the existing code throws an error that 8UC3 is not a valid encoding, but if we pass rgb8 from the message then things work fine. The encoding in the image should always be more descriptive than just the bit and channel size.
If encoding is not filled in, the existing behavior is used as a fallback