migrate and update image_proc docs #925
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
mikeferguson
commented
Feb 4, 2024
mikeferguson
commented
- move component documentation from ros wiki, update for various changes
- add tutorial on how to run components
- update tutorial on debayer/rectify to use launch file
- remove image_proc node, it has always been completely broken and the launch file has the same (but working) functionality
- update launch file to support namespace parameter for tutorial
* move component documentation from ros wiki, update for various changes * add tutorial on how to run components * update tutorial on debayer/rectify to use launch file * remove image_proc node, it has always been completely broken and the launch file has the same (but working) functionality * update launch file to support namespace parameter for tutorial
|
Testing done:
|
ahcorde
requested changes
Feb 5, 2024
Co-authored-by: Alejandro Hernández Cordero <[email protected]>
|
All great suggestions - but I'm going to skip adding build instructions to the README since we aren't doing anything fancy - just using rosdoc2 in the standard way |
mikeferguson
added a commit
that referenced
this pull request
Feb 5, 2024
I didn't actually rebuild with the suggestions in #925 - but this is actually proper rendering (even my three-ticks version wasn't quite pretty)
mikeferguson
pushed a commit
that referenced
this pull request
Feb 28, 2024
ahcorde
pushed a commit
that referenced
this pull request
Mar 26, 2024
mikeferguson
pushed a commit
that referenced
this pull request
Apr 23, 2024
Backport pull request #925 which solves issue #952 by adding the `namespace` parameter to the `image_proc` launch file Co-authored-by: Lucas Wendland <[email protected]>
Kotochleb
pushed a commit
to Kotochleb/image_pipeline
that referenced
this pull request
May 27, 2024
* move component documentation from ros wiki, update for various changes * add tutorial on how to run components * update tutorial on debayer/rectify to use launch file * remove image_proc node, it has always been completely broken and the launch file has the same (but working) functionality * update launch file to support namespace parameter for tutorial
Kotochleb
pushed a commit
to Kotochleb/image_pipeline
that referenced
this pull request
May 27, 2024
I didn't actually rebuild with the suggestions in ros-perception#925 - but this is actually proper rendering (even my three-ticks version wasn't quite pretty)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.