add image_flip node #942
Merged
add image_flip node #942
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
After reviewing this closer - I may also make both nodes derive from a base class to avoid so much duplicated code |
ahcorde
requested changes
Aug 20, 2024
mikeferguson
force-pushed
the
rolling-image-flip
branch
from
3e0a03d to
c5787d9
Compare
|
@mikeferguson ready for review ? |
Yes, I was originally planning to try and merge the two nodes... but, yeah, that turns out to be messier than I thought. |
ahcorde
approved these changes
Dec 11, 2024
|
@mikeferguson do you want to backport this PR ? |
|
https://github.com/Mergifyio backport jazzy |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Dec 11, 2024
This is a continuation of #756: * [x] Squashed 16 commits in original PR for ease of rebase/review * [x] Moved node into image_rotate package * [x] Added lazy subscriber * [x] Removes QoS parameters - will add proper QoS overrides in a different PR (when we do the same for image_rotate) * [x] Adds documentation --------- Co-authored-by: David Conner <[email protected]> Co-authored-by: Alejandro Hernández Cordero <[email protected]> (cherry picked from commit c8622e7)
5 tasks
ahcorde
pushed a commit
that referenced
this pull request
Dec 11, 2024
This is a continuation of #756: * [x] Squashed 16 commits in original PR for ease of rebase/review * [x] Moved node into image_rotate package * [x] Added lazy subscriber * [x] Removes QoS parameters - will add proper QoS overrides in a different PR (when we do the same for image_rotate) * [x] Adds documentation<hr>This is an automatic backport of pull request #942 done by [Mergify](https://mergify.com). Co-authored-by: Michael Ferguson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a continuation of #756: