Fix parameter names in components.rst #959
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikeferguson
approved these changes
Mar 8, 2024
|
Thanks for catching that! CI is going to fail due to rolling transition - but this doesn't change code, so merging. |
|
Wow, thanks for the quick review! |
You got lucky, I typically do one or two checks a day on GitHub notifications, and this came through just as I was doing that check. |
Kotochleb
pushed a commit
to Kotochleb/image_pipeline
that referenced
this pull request
May 27, 2024
In the docs for `image_proc::CropDecimateNode` , change the parameter names `x_offset` and `y_offset` to `offset_x` and `offset_y`, matching the actual names of parameters defined in crop_decimate.cpp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the docs for
image_proc::CropDecimateNode, change the parameter namesx_offsetandy_offsettooffset_xandoffset_y, matching the actual names of parameters defined in crop_decimate.cpp.