-
Notifications
You must be signed in to change notification settings - Fork 734
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: cv2.aruco.interpolateCornersCharuco is deprecated #979
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahcorde
approved these changes
May 17, 2024
https://github.com/Mergifyio backport jazzy |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
May 17, 2024
There has been API Changes in the newer releases of opencv2 (from 4.8.0). The PR addresses this by supporting both the old and new APIs. updated Syntax ``` charucodetector = cv2.aruco.CharucoDetector(board) charuco_corners, charuco_ids, marker_corners, marker_ids = charucodetector.detectBoard(image) ``` before 4.8.0 ``` marker_corners, marker_ids, rejectedImgPoints = cv2.aruco.detectMarkers( image, dictionary) retval, charuco_corners, charuco_ids = cv2.aruco.interpolateCornersCharuco( marker_corners, marker_ids, image, board) ``` See the changed examples in the main opencv2 repo: https://github.com/opencv/opencv/blob/f9a59f2592993d3dcc080e495f4f5e02dd8ec7ef/samples/python/calibrate.py#L110 (cherry picked from commit a8cd840)
ahcorde
pushed a commit
that referenced
this pull request
May 24, 2024
#980) There has been API Changes in the newer releases of opencv2 (from 4.8.0). The PR addresses this by supporting both the old and new APIs. updated Syntax ``` charucodetector = cv2.aruco.CharucoDetector(board) charuco_corners, charuco_ids, marker_corners, marker_ids = charucodetector.detectBoard(image) ``` before 4.8.0 ``` marker_corners, marker_ids, rejectedImgPoints = cv2.aruco.detectMarkers( image, dictionary) retval, charuco_corners, charuco_ids = cv2.aruco.interpolateCornersCharuco( marker_corners, marker_ids, image, board) ``` See the changed examples in the main opencv2 repo: https://github.com/opencv/opencv/blob/f9a59f2592993d3dcc080e495f4f5e02dd8ec7ef/samples/python/calibrate.py#L110<hr>This is an automatic backport of pull request #979 done by [Mergify](https://mergify.com). Co-authored-by: Földi Tamás <[email protected]>
Kotochleb
pushed a commit
to Kotochleb/image_pipeline
that referenced
this pull request
May 27, 2024
…n#979) There has been API Changes in the newer releases of opencv2 (from 4.8.0). The PR addresses this by supporting both the old and new APIs. updated Syntax ``` charucodetector = cv2.aruco.CharucoDetector(board) charuco_corners, charuco_ids, marker_corners, marker_ids = charucodetector.detectBoard(image) ``` before 4.8.0 ``` marker_corners, marker_ids, rejectedImgPoints = cv2.aruco.detectMarkers( image, dictionary) retval, charuco_corners, charuco_ids = cv2.aruco.interpolateCornersCharuco( marker_corners, marker_ids, image, board) ``` See the changed examples in the main opencv2 repo: https://github.com/opencv/opencv/blob/f9a59f2592993d3dcc080e495f4f5e02dd8ec7ef/samples/python/calibrate.py#L110
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There has been API Changes in the newer releases of opencv2 (from 4.8.0). The PR addresses this by supporting both the old and new APIs.
updated Syntax
before 4.8.0
See the changed examples in the main opencv2 repo:
https://github.com/opencv/opencv/blob/f9a59f2592993d3dcc080e495f4f5e02dd8ec7ef/samples/python/calibrate.py#L110