Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add open3d dependency into package.xml #25

Merged
merged 1 commit into from
Jun 2, 2022

Conversation

wep21
Copy link

@wep21 wep21 commented Jun 1, 2022

add open3d dependecy because libopen3d-dev is available as apt package on jammy.

@wep21
Copy link
Author

wep21 commented Jun 1, 2022

@nkhedekar Matnay Currently libopen3d-dev is available on jammy, so oped3d dependency can be added into package.xml for rolling/humble distribution. Could you create ros2 and humble branch? I will change the target branch after you create the branches. Also, as I mentioned in this issue, I would like to proceed to release this package. Thanks in advance.

@SteveMacenski
Copy link
Member

Agree, its on my todo list for tomorrow

@SteveMacenski
Copy link
Member

@wep21 Humble and Ros2 are up, ended up being on a late night webinar so got to it during that.

If you open up tickets for both, I'll merge and then run a release for Humble + Rolling

@wep21 wep21 changed the base branch from foxy-devel to ros2 June 2, 2022 04:02
@wep21
Copy link
Author

wep21 commented Jun 2, 2022

@SteveMacenski Thanks. I changed the target branch of this PR to ros2 branch and created a new PR to humble branch.

@SteveMacenski SteveMacenski merged commit 9bf8585 into ros-perception:ros2 Jun 2, 2022
@wep21 wep21 deleted the add-open3d-dependency branch June 2, 2022 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants