Python 3 compatibility (Melodic) #312
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Newer compilers would optimize do_numpy_import() out due to not every path returning a value. Return type for this function should be a pointer (since the NUMPY_IMPORT_ARRAY_RETVAL in import_array() is NULL by default).
6 tasks
Merged
|
Hi @sfalexrog and others that have given a thumbs up on the PR, I've recently become the maintainer of this repo, and I'm going through the list of PRs to figure out which ones are still active and important. I'm going to close this PR out as I believe it is now stale, but if anyone thinks these changes are still relevant, please comment on this PR and we can get it re-opened. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This P/R does several things:
The Travis job is more of a temporary hack, since it cannot use prebuilt ROS packages and has to rebuild everything from source. Hopefully this can be removed once Noetic is out.