Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change module.hpp to align with Noetic #342

Merged
merged 1 commit into from
Jul 10, 2020
Merged

Change module.hpp to align with Noetic #342

merged 1 commit into from
Jul 10, 2020

Conversation

mjcarroll
Copy link
Contributor

This makes module.hpp match what is in the noetic version.

It should also fix #339 by correctly returning a nullptr from do_numpy_import.

The reason for this is explained in #292.

@mjcarroll
Align module.hpp with noetic
f41fc9b 
Signed-off-by: Michael Carroll <[email protected]>
@mjcarroll mjcarroll changed the base branch from noetic to ros2 June 26, 2020 18:33
@mjcarroll
Copy link
Contributor Author

CC: @SteveMacenski

@mjcarroll mjcarroll mentioned this pull request Jul 9, 2020
Closed
jacobperron
jacobperron approved these changes Jul 9, 2020
View reviewed changes
Copy link
Contributor

@jacobperron jacobperron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mjcarroll mjcarroll merged commit 102a9d5 into ros2 Jul 10, 2020
@mjcarroll mjcarroll deleted the align_with_noetic branch July 10, 2020 14:44
@clalancette clalancette mentioned this pull request Jul 15, 2020
Merged
@mjcarroll mjcarroll mentioned this pull request Jul 28, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jacobperron jacobperron jacobperron approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Foxy] cv_bridge import broken with unreported exception
2 participants
@mjcarroll @jacobperron