joy_teleop: Do not require deadman input for axis mapping #71
Conversation
|
@bmagyar could this get a review please? |
| @@ -152,36 +152,6 @@ def test_teleop_axis_mappings_missing_axis_or_button(self): | |||
| self.assertEqual(joy_teleop_process.exit_code, 1) | |||
| self.assertTrue('must have an axis, button, or value' in joy_teleop_process.output) | |||
|
|
|||
| def test_teleop_axis_mappings_missing_offset(self): | |||
There was a problem hiding this comment.
I think these tests still hold value in showing that things are handled despite some things missing. Is it ok to leave them?
There was a problem hiding this comment.
These tests are expecting an error when there isn't one after the changes in this PR.
Do you mean you also want the checks for empty offset and scale put back into the code?
|
Please specify what your target distro is with this |
I use galactic, personally. I don't see why this wouldn't work on foxy as well. |
|
Hi @bmagyar - poke. |
|
Any updates on this PR? |
|
Seems to fail all CI tests now. I will fix this when I get a moment and hopefully it can be merged. |
|
I am still interested in this change |
|
Appears to be resolving #74 |
|
Yeah I would have liked to have had these changes merged years ago. |
Hello,
While attempting to use this teleop package for my purposes, I found I couldn't simply map an axis without specifying a "deadman switch" which in this case is more accurately a trigger. These changes improve the behaviour of the mapping.
This code should work on foxy, but has been tested on galactic only.
Russ