Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perception_open3d: 0.1.1-1 in 'rolling/distribution.yaml' [bloom] #33447

Merged

Conversation

SteveMacenski
Copy link
Member

Increasing version of package(s) in repository perception_open3d to 0.1.1-1:

@github-actions github-actions bot added the rolling Issue/PR is for the ROS 2 Rolling distribution label Jun 2, 2022
@SteveMacenski
Copy link
Member Author

Blacklist for RHEL added due to lack of open3d key ros2/ros_buildfarm_config#244

@wep21
Copy link
Contributor

wep21 commented Jun 3, 2022

As for versions, it may be better to make the rolling one greater than the humble one.

Copy link
Contributor

@clalancette clalancette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides the comment inline, I agree that it does feel a little weird to have Rolling behind Humble. It's not wrong, per-se, but it is confusing. Again, if you want to continue anyway, just let me know.

- open3d_conversions
tags:
release: release/rolling/{package}/{version}
url: https://github.com/ros-gbp/perception_open3d-release.git
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI, we highly recommend that you use a release repository in https://github.com/ros2-gbp for Rolling. If you don't do this, then this package can't automatically be rolled over into the next distribution.

I won't outright block on this, but let me know explicitly if you want to stay with your current release repository.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ros-perception/perception_open3d#24 conversation is in the works, I need access to the org to do so. I'm a member of the org but not admin to move / create new repositories which I need to transfer this project (and probably several others in the future)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Either way, once the repo is transferred, github will automatically redirect to the new location without breaking the ROS (1) link version

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While GitHub redirection will work, I'm not sure whether our tools will follow that properly. @nuclearsandwich can answer that. The easiest thing to do here is to move it over and just use the ros2-gbp repository, that way there is no question. I'll see what I can do about getting ros-perception/perception_open3d#24 resolved.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

@SteveMacenski
Copy link
Member Author

SteveMacenski commented Jun 6, 2022

Next Rolling update I'll push past Humble, but right now its actually not head of it in any particular way so just a minor version update for release. Once it surpasses Humble's version, it'll be assigned 0.3.x to be given to iron. Its maybe not super clear to others, but it helps me keep track of Rolling ahead/behind of released versions

@nuclearsandwich nuclearsandwich merged commit 3fdd9e5 into ros:master Jun 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rolling Issue/PR is for the ROS 2 Rolling distribution
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants