Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perception_open3d: 0.1.1-1 in 'rolling/distribution.yaml' [bloom] #33447

Merged
merged 1 commit into from
Jun 7, 2022
Merged

perception_open3d: 0.1.1-1 in 'rolling/distribution.yaml' [bloom] #33447

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions rolling/distribution.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2514,6 +2514,19 @@ repositories:
url: https://github.com/ros-perception/pcl_msgs.git
version: ros2
status: maintained
perception_open3d:
release:
packages:
- open3d_conversions
tags:
release: release/rolling/{package}/{version}
url: https://github.com/ros-gbp/perception_open3d-release.git
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI, we highly recommend that you use a release repository in https://github.com/ros2-gbp for Rolling. If you don't do this, then this package can't automatically be rolled over into the next distribution.

I won't outright block on this, but let me know explicitly if you want to stay with your current release repository.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ros-perception/perception_open3d#24 conversation is in the works, I need access to the org to do so. I'm a member of the org but not admin to move / create new repositories which I need to transfer this project (and probably several others in the future)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Either way, once the repo is transferred, github will automatically redirect to the new location without breaking the ROS (1) link version

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While GitHub redirection will work, I'm not sure whether our tools will follow that properly. @nuclearsandwich can answer that. The easiest thing to do here is to move it over and just use the ros2-gbp repository, that way there is no question. I'll see what I can do about getting ros-perception/perception_open3d#24 resolved.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

version: 0.1.1-1
source:
type: git
url: https://github.com/ros-perception/perception_open3d.git
version: ros2
status: developed
perception_pcl:
doc:
type: git
Expand Down