Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

librealsense2: 2.54.1-2 in 'rolling/distribution.yaml' [bloom] #37808

Closed
wants to merge 1 commit into from
Closed

librealsense2: 2.54.1-2 in 'rolling/distribution.yaml' [bloom] #37808

wants to merge 1 commit into from

Conversation

SamerKhshiboun
Copy link
Contributor

Increasing version of package(s) in repository librealsense2 to 2.54.1-2:

@github-actions github-actions bot added the rolling Issue/PR is for the ROS 2 Rolling distribution label Jun 29, 2023
@Nir-Az Nir-Az mentioned this pull request Jun 29, 2023
Closed
clalancette
clalancette requested changes Jun 30, 2023
View reviewed changes
rolling/distribution.yaml
release:
tags:
release: release/rolling/{package}/{version}
url: https://github.com/IntelRealSense/librealsense2-release.git
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To release into Rolling, we need to have the release repository be in the https://github.com/ros2-gbp organization. The basic reason is so that we have write access when we go to branch off of Rolling. To create that, please open a ticket on https://github.com/ros2-gbp/ros2-gbp-github-org

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Opened PR, waiting for merge:
ros2-gbp/ros2-gbp-github-org#297

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@clalancette Hi,
We opened a PR 2 weeks ago as you asked.
Can this please be reviewed / merged?

@clalancette clalancette added the changes requested Maintainers have asked for changes to the pull request label Jun 30, 2023
@quarkytale quarkytale added the persistent Issue/PR won't be marked as stale if inactive for a while. label Jul 21, 2023
@sloretz sloretz added the held for sync Issue/PR has been held because the distribution is in a sync hold label Aug 9, 2023
@sloretz
Copy link
Contributor

sloretz commented Aug 9, 2023

Holding for an upcoming Rolling sync

@mjcarroll mjcarroll added ros2-gbp Pending release into ros2-gbp and removed held for sync Issue/PR has been held because the distribution is in a sync hold labels Aug 29, 2023
@sloretz sloretz added the held for sync Issue/PR has been held because the distribution is in a sync hold label Sep 27, 2023
@sloretz
Copy link
Contributor

sloretz commented Sep 27, 2023

Holding for an upcoming Rolling sync

@sloretz sloretz removed the held for sync Issue/PR has been held because the distribution is in a sync hold label Oct 2, 2023
@clalancette
Copy link
Contributor

I'm going to close this PR until the discussion in ros2-gbp/ros2-gbp-github-org#297 is sorted out. Once that is done, a new PR is going to have to be opened anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nir-Az Nir-Az Nir-Az left review comments

@clalancette clalancette clalancette requested changes

@nuclearsandwich nuclearsandwich Awaiting requested review from nuclearsandwich nuclearsandwich is a code owner

Assignees
No one assigned
Labels
changes requested Maintainers have asked for changes to the pull request persistent Issue/PR won't be marked as stale if inactive for a while. rolling Issue/PR is for the ROS 2 Rolling distribution ros2-gbp Pending release into ros2-gbp
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@SamerKhshiboun @sloretz @clalancette @Nir-Az @mjcarroll @quarkytale