-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
restore CI output group folding in github actions #38167
Conversation
See official docs for details: https://docs.github.com/en/actions/using-workflows/ workflow-commands-for-github-actions#grouping-log-lines
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks like a good change to me and makes the CI easier to go through. @clalancette, what do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've left one thing to change in line, but this looks great.
Sorry, I just added an update. @audrow Can I re-request your review? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems good to me, but I'll wait for another review from @audrow before merging in.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
Related: #25334
See official docs for details:
https://docs.github.com/en/actions/using-workflows/workflow-commands-for-github-actions#grouping-log-lines