Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

restore CI output group folding in github actions #38167

Merged
merged 6 commits into from
Aug 15, 2023

Conversation

SubaruArai
Copy link
Contributor

@SubaruArai SubaruArai marked this pull request as ready for review August 7, 2023 01:26
Copy link
Contributor

@audrow audrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a good change to me and makes the CI easier to go through. @clalancette, what do you think?

Copy link
Contributor

@clalancette clalancette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've left one thing to change in line, but this looks great.

test/fold_block.py Outdated Show resolved Hide resolved
@audrow audrow requested a review from clalancette August 8, 2023 01:06
@SubaruArai
Copy link
Contributor Author

SubaruArai commented Aug 8, 2023

Sorry, I just added an update.
I didn't like that cls_ remained in the module.

@audrow Can I re-request your review?

@SubaruArai SubaruArai requested a review from audrow August 8, 2023 01:15
Copy link
Contributor

@clalancette clalancette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems good to me, but I'll wait for another review from @audrow before merging in.

Copy link
Contributor

@audrow audrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@audrow audrow merged commit b9dadc2 into ros:master Aug 15, 2023
4 checks passed
@SubaruArai SubaruArai deleted the ci/fold_output branch August 15, 2023 23:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants