Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

camera_info_manager_py: 1.0.0-1 in 'jazzy/distribution.yaml' [bloom] #43325

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

civerachb-cpr
Copy link
Contributor

Increasing version of package(s) in repository camera_info_manager_py to 1.0.0-1:

camera_info_manager_py

* Ros2 (#2 <https://github.com/clearpathrobotics/camera_info_manager_py/issues/2>)
  * Run magic converter
  * Ament_python package
  * Fix some imports
  * Remove references to cpp camera info manager.
  Disable tests
  * Linting
  * Fully Remove old tests
  * Add lint tests
  * Final tests
  * Remove pep257 from depends
* Contributors: Michael Hosmar

@github-actions github-actions bot added the jazzy Issue/PR is for the ROS 2 Jazzy distribution label Nov 1, 2024
@marcoag
Copy link
Contributor

marcoag commented Nov 4, 2024

It seems this is is being released from a fork of the original repo we have in other distros (under ros-perception org), is there any reason for that?

@marcoag marcoag added the more information needed Maintainers have asked for additional information label Nov 4, 2024
@civerachb-cpr
Copy link
Contributor Author

The original ros-perception repo seems to have been abandoned? The last commit on that repo was in 2016, and it hasn't been bloomed for any recent ROS 1 nor ROS 2 distributions.

If the old ros-perception maintainers are still active and want to create the appropriate branches for us to open merge requests we'd be happy to do that. But given the lack of activity on that repo this seemed like the more expeditious route.

Specifically we're blooming this as it's a dependency of the axis_camera packages that have not been available as binaries for a very long time. We've updated those packages to support Humble and Jazzy, but need to get this dependency sorted out before we can bloom the camera driver.

@sloretz
Copy link
Contributor

sloretz commented Nov 15, 2024

@jack-oquin FYI. Thoughts on this fork adding ROS 2 support to camera_info_manager_py?

@ahcorde
Copy link
Contributor

ahcorde commented Nov 19, 2024

@civerachb-cpr what's about adding this package to image_common ? camera_info_manager_py is a Python wrapper of camera_info_manager. I would say it is the better place to locate this package if the mantainer is not responding anymore. Do you mind to open a PR there ?

@civerachb-cpr
Copy link
Contributor Author

@civerachb-cpr what's about adding this package to image_common ? camera_info_manager_py is a Python wrapper of camera_info_manager. I would say it is the better place to locate this package if the mantainer is not responding anymore. Do you mind to open a PR there ?

I've created an issue on image_common asking if they're willing to take ownership of the package and are open to your proposal: ros-perception/image_common#331

I'm hesitant to just assign it to them, since that implies they're become responsible for maintaining the Python package, which may not be something they're willing to do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
jazzy Issue/PR is for the ROS 2 Jazzy distribution more information needed Maintainers have asked for additional information
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants